On Friday, 27 May 2016, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, May 27, 2016 at 7:35 AM, Emil Velikov <emil.l.veli...@gmail.com > <javascript:_e(%7B%7D,'cvml','emil.l.veli...@gmail.com');>> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com >> <javascript:_e(%7B%7D,'cvml','emil.veli...@collabora.com');>> >> >> Otherwise we'll error out if build from a release tarball. >> >> Cc: Jason Ekstrand <jason.ekstr...@intel.com >> <javascript:_e(%7B%7D,'cvml','jason.ekstr...@intel.com');>> >> Cc: Kristian Høgsberg Kristensen <k...@bitplanet.net >> <javascript:_e(%7B%7D,'cvml','k...@bitplanet.net');>> >> --- >> This patch isn't going to fly obviously but is just enough to get things >> building ;-) >> > > You're right. It won't. :-) > > I think what we need is to ship something that provides MESA_GIT_SHA1 in > the tarball. The purpose of this is to ensure that any shader caches get > 100% invalidated if the mesa version changes at all. When Timothy lands > his shader cache stuff, we'll need this in the GL driver as well so we > might as well find a solution now. > > Indeed. I was looking at how GL does it only to find it isn't wired up yet. And yes shipping git_sha1.h sounds like a good solution. Question is do we want to print the sha in other places (GL_VERSION iirc) for release builds ? I'd go with yes on that one as well.
I'm on the move(train) atm so it might be a little late in the day for anyone to review 'v2'. > All of the other (not this one) anv/isl patches in the series are > > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net > <javascript:_e(%7B%7D,'cvml','ja...@jlekstrand.net');>> > Thanks. Emil
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
