On Wed, Apr 27, 2016 at 5:05 AM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Monday, April 25, 2016 5:54:28 PM PDT Jordan Justen wrote: >> Fixes the OpenGLES 3.1 CTS: >> * ESEXT-CTS.draw_elements_base_vertex_tests.invalid_mapped_bos >> >> Because this is triggering the error message after the normal API >> validation phase, we don't have the API function name available, and >> therefore we generate an error message that is a little confusing: >> >> Mesa: User error: GL_INVALID_OPERATION in Vertex buffers are mapped during > draw call! >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95142 >> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Kenneth Graunke <kenn...@whitecape.org> >> --- >> >> Perhaps it would be better to push the vbo_bind_arrays before API >> validation, and then make this check be part of API validation... > > This looks fine to me, though it'd be nice to get a review from someone > else who's familiar with this code. Cc'ing Marek and Fredrik in case > they have an opinion.
The patch says it's a GLES fix, but it modifies desktop GL behavior too. Is that intentional? Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
