Am 07.04.2016 um 00:47 schrieb Nicolai Hähnle:
> From: Nicolai Hähnle <nicolai.haeh...@amd.com>
>
> The previous value of 18 was motivated by having drivers that want to expose
> 16 samplers but also use some additional samplers for internal use. Raising
> the value even higher isn't going to hurt that case.
>
> On the other hand, some drivers actually use PIPE_MAX_SAMPLERS as the number
> of samplers they expose externally, so raising this number above 32 is fragile
> (because several places in the code use bitfields, and tracking down and
> widening all of them is prone to miss some case).
> ---
> src/gallium/include/pipe/p_state.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_state.h
> b/src/gallium/include/pipe/p_state.h
> index 5ab5372..f0ec96a 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -57,7 +57,7 @@ extern "C" {
> #define PIPE_MAX_CLIP_PLANES 8
> #define PIPE_MAX_COLOR_BUFS 8
> #define PIPE_MAX_CONSTANT_BUFFERS 32
> -#define PIPE_MAX_SAMPLERS 18 /* 16 public + 2 driver internal */
> +#define PIPE_MAX_SAMPLERS 32
> #define PIPE_MAX_SHADER_INPUTS 80 /* 32 GENERIC + 32 PATCH + 16 others */
> #define PIPE_MAX_SHADER_OUTPUTS 80 /* 32 GENERIC + 32 PATCH + 16 others */
> #define PIPE_MAX_SHADER_SAMPLER_VIEWS 32
>
Looks reasonable to me.
For 1-4:
Reviewed-by: Roland Scheidegger <srol...@vmware.com>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
