On 03/31/2016 07:02 AM, Marek Olšák wrote:
On Thu, Mar 31, 2016 at 3:15 AM, Dave Airlie <airl...@gmail.com> wrote:
On 31 March 2016 at 11:06, Brian Paul <bri...@vmware.com> wrote:
It was kind of overloaded, returning two different things.  Now get
the index of the shadow reference src register with a new
tgsi_util_get_shadow_ref_src_index() function.

To verify the new code, I added some temp/debug code which looped
over all TGSI_TEXTURE_x values, calling the old function and new and
checking that the returned indexes matched.

Also tested piglit "shadow" tests with softpipe/llvmpipe.
No testing of ilo and radeonsi changes.

Maybe you could make tgsi_util_get_texture_coord_dim, take an unsigned
while you are here.

Not sure if that's a good idea if the function returns -1 on error.

I think Dave was suggesting changing the function parameter to unsigned, not the return type. That's the change I made.

-Brian


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to