On Mon, Mar 28, 2016 at 3:04 PM, Ian Romanick <i...@freedesktop.org> wrote:
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>> index 9aec425..731b62e 100644
>> --- a/src/mesa/main/bufferobj.c
>> +++ b/src/mesa/main/bufferobj.c
>> @@ -148,8 +148,8 @@ get_buffer_target(struct gl_context *ctx, GLenum target)
>> }
>> break;
>> case GL_TEXTURE_BUFFER:
>> - if (ctx->API == API_OPENGL_CORE &&
>> - ctx->Extensions.ARB_texture_buffer_object) {
>> + if (_mesa_has_ARB_texture_buffer_object(ctx) ||
>> + _mesa_has_OES_texture_buffer(ctx)) {
>
> It looks like every place that uses one of these functions uses the
> other too. Maybe add _mesa_has_texture_buffer?
I think I'm going to skip this one -- we don't really have a lot of
such helpers. We have them for the various stages, presumably because
they're used all over the place, but not for these types of
extensions. I wouldn't oppose a policy change on that, and having more
such helpers, although I wouldn't push for it either :)
Thanks for looking through the series! Perhaps you can have another
pass at the multisample one too? :)
-ilia
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
