On Wed, Mar 16, 2016 at 2:14 PM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > On 16-03-16 15:55, Ilia Mirkin wrote: >> >> This approach leads to the emitters needing to know about both global and >> buffer, even though at that point, they are identical. I was thinking that >> in the lowering logic, buffer would just get rewritten as global (with the >> offset added), thus not needing any change to the emitters. What do you >> think about such an approach? > > > I was actually thinking the same, but I was a bit afraid I might break > something by doing that. I'm willing to try though, but the result is > going to need some extra testing by others I believe. > > Questions: > > 1) Any tests I can run to test the buffer paths ?
bin/arb_shader_storage_buffer_object-* (in piglit) Also a ton of stuff in dEQP, although some of it fails. (--deqp-case='*ssbo*') > > 2) So the resulting patch, which would replace this one, and make most > of the "nouveau: codegen: Add support for OpenCL global memory buffers" > unnecessary would look something like this: > 2a) Add FILE_MEMORY_BUFFER as nv50_ir::FILE_* type > 2b) Use it in nv50_ir_from_tgsi.cpp instead of GLOBAL > 2c) Use it in nv50_ir_lowering_ to check for buffer accesses, > and when adding the offset change the file_type to GLOBAL > > Right ? Sounds good to me! -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
