On 02/25/2016 12:58 AM, Kenneth Graunke wrote:
On Wednesday, February 24, 2016 4:45:42 PM PST Brian Paul wrote:
Use the typical _snprintf work-around.
---
  src/perf/glsl-compile-time.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/src/perf/glsl-compile-time.c b/src/perf/glsl-compile-time.c
index 917073c..a8e774f 100644
--- a/src/perf/glsl-compile-time.c
+++ b/src/perf/glsl-compile-time.c
@@ -20,6 +20,10 @@
  #include "glut_wrap.h"
  #include "shaderutil.h"

+#if defined(_MSC_VER)
+#define snprintf _snprintf
+#endif
+

  #define MAX_PROGRAMS 10000



Not sure you really need review on a demo you wrote yourself last
month... :)  This looks reasonable to me, though.

Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>

Well, if someone were a zealous bikeshedder they might care that snprintf() != _snprintf() regarding whether a terminating zero is always put in the buffer.

Thanks, already pushed.

-Brian

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to