On 16 February 2016 at 07:02, Michel Dänzer <mic...@daenzer.net> wrote: > On 14.02.2016 23:41, Mauro Rossi wrote: >> >> From: Mauro Rossi <issor.or...@gmail.com <mailto:issor.or...@gmail.com>> >> Date: Sun, 14 Feb 2016 15:34:16 +0100 >> Subject: [PATCH 1/2] android: add support for strchrnul >> >> Android Bionic has no strchrnul in string functions, >> radeonsi uses strchrnul, so we need an implementation. >> >> strchrnul.h is added in top mesa include path. > > Gallium code (at least outside of src/gallium/state_trackers) is not > supposed to include headers from the toplevel include directory. This > header should be in src/util/ instead. > If we consider this a compatibility wrapper then include/ is fine (alongside a name like gnu_string.h). Although I'm thinking about a shorter fix -> s/strchrnul/util_strchrnul/. Gallium already has (and uses) an util function.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
