On 12/05/2015 11:47 AM, Alejandro Piñeiro wrote:
Recently I realized that there are two methods that provides the same functionality, _mesa_is_array_texture (at teximage.[ch]) and _mesa_tex_target_is_array (at texformat.[ch]) so it makes sense to remove one.This two-patch series removes _mesa_is_array_texture just because _mesa_tex_target_is_array is older. But it is worth to note that perhaps some people would prefer the other way, because teximage.h already have other utility methods like this (example: _mesa_is_proxy_texture) and because _mesa_is_array_texture has a more proper returning value based on this review: http://lists.freedesktop.org/archives/mesa-dev/2015-February/076533.html So although if someone prefers to keep the newer instead of the older, I can make the opposite change.
I'd prefer to keep _mesa_is_array_texture() because: 1. it returns bool instead of GLboolean 2. it's not related to the texture format (texformat.c) 3. the name's a little shorter -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
