On Fri, Nov 27, 2015 at 6:50 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 25 November 2015 at 22:01, Matt Turner <matts...@gmail.com> wrote: >> On Wed, Nov 25, 2015 at 1:32 PM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: > >>> --- a/src/Makefile.am >>> +++ b/src/Makefile.am >>> @@ -23,6 +23,7 @@ SUBDIRS = . gtest util mapi/glapi/gen mapi >>> >>> # XXX: conditionally include >>> SUBDIRS += compiler >>> +SUBDIRS += compiler/nir >> >> We have a non-recursive build in src/glsl today. I don't want to go >> backwards. > Not sure I fully get that can you elaborate ? Are you concerned that > things won't build in parallel, increasing the compilation times ? > > On my dual core system running with -j2 results in approx 15 seconds > increase. I'm willing to take that trade off for the improved > readability. What is the difference on your system ?
src/glsl has single Makefile that builds libglcpp, glcpp, libglsl, glsl_compiler, glsl_test, libnir, and various test programs, allowing all of these things to happen in parallel. The Makefile is perfectly maintainable as it is and there's no advantage of splitting it, especially when the work has been done to get things to this state (commits 86d30dea, efd201ca) and NIR was added without an additional Makefile. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
