On Thu, 2015-11-26 at 00:36 +0000, Emil Velikov wrote: > These new (relative to ARB_debug_output) tokens, have been explicitly > separated from the existing ones in the spec text. With the reference > to glDebugMessageInsert was dropped. > > At the same time, further down the spec says: > "The value of <type> must be one of the values from Table 5.4" > > ... and these two are listed in Table 5.4. > > The GL 4.3 and GLES 3.2 do not give any hints on the former > 'definition', plus CTS requires that the tokens are valid values for > glDebugMessageInsert.
I still think this is a spec bug but if it helps pass the tests I guess it doesn't do much harm. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> > > Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> > --- > src/mesa/main/errors.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c > index af6fe91..39e5642 100644 > --- a/src/mesa/main/errors.c > +++ b/src/mesa/main/errors.c > @@ -922,9 +922,9 @@ validate_params(struct gl_context *ctx, unsigned > caller, > case GL_DEBUG_TYPE_PORTABILITY_ARB: > case GL_DEBUG_TYPE_OTHER_ARB: > case GL_DEBUG_TYPE_MARKER: > - break; > case GL_DEBUG_TYPE_PUSH_GROUP: > case GL_DEBUG_TYPE_POP_GROUP: > + break; > case GL_DONT_CARE: > if (caller == CONTROL) > break; _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
