On Wed, Jun 22, 2011 at 11:38 AM, Ian Romanick <i...@freedesktop.org> wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > --- > configure.ac | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index c9dd8a7..76736c0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -562,6 +562,12 @@ AC_ARG_WITH([gallium-drivers], > [with_gallium_drivers="$withval"], > [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"]) > > +# Doing '--without-gallium-drivers' will set this variable to 'no'. Clear it > +# here so that the script doesn't choke on an unknown driver name later. > +if test "x$with_gallium_drivers" = "xno"; then > + with_gallium_drivers='' > +fi
Nitpicky, but the other thing that would be nice is if bare --with-gallium-drivers becomes $GALLIUM_DRIVERS_DEFAULT. Could be: case "$with_gallium_drivers" in yes) with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT" ;; no) with_gallium_drivers='' ;; esac Either way, good to catch this case. Reviewed-by: Dan Nicholson <dbn.li...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
