On 06/17/2011 02:36 PM, Eric Anholt wrote:
We would still want to consider that data as being in a VBO even if we
managed to produce this case, which as far as I know we can't.
---
  src/mesa/vbo/vbo_rebase.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c
index 9068ae2..15e5895 100644
--- a/src/mesa/vbo/vbo_rebase.c
+++ b/src/mesa/vbo/vbo_rebase.c
@@ -90,8 +90,7 @@ GLboolean vbo_any_varyings_in_vbos( const struct 
gl_client_array *arrays[] )
     GLuint i;

     for (i = 0; i<  VERT_ATTRIB_MAX; i++)
-      if (arrays[i]->StrideB&&
-         arrays[i]->BufferObj->Name != 0)
+      if (arrays[i]->BufferObj->Name != 0)
         return GL_TRUE;

     return GL_FALSE;

Reviewed-by: Brian Paul <bri...@vmware.com>

As a clean-up you might want to use the _mesa_is_bufferobj() function instead of Name!=0 to test if the array is stored in a VBO. We're doing that in most other places in the VBO code.

For people reading along: all vertex arrays have pointers to a buffer object but for user-space arrays we point to a dummy buffer object with Name=0.

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to