On 5/20/11 8:50 PM, Jose Fonseca wrote:

I don't care which approach we go with.  This will likely fix it
everywhere, but I'd like there to be a comment explaining why the
return
type must not be unsigned.  Otherwise someone will come along in the
future and make it unsigned in the name of "code cleanup."

I agree with Ian: Adam's patch is good, but a comment would be useful, as the 
implicit coercion to unsigned is both unfortunate and unintuitive.

Makes sense. Added a comment above _mesa_get_format_bytes and pushed, thanks.

- ajax
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to