On 05/19/2011 01:19 PM, Chad Versace wrote: > On 05/19/2011 05:13 AM, Ian Romanick wrote: >> From: Ian Romanick <ian.d.roman...@intel.com> >> >> Since RowStride might be negative, we want a signed result. On 64-bit >> platforms, an unsigned 32-bit result added to a 64-bit pointer will >> give the wrong answer. > > Looks like all eyes were on this bug. I was just about a submit this > patch to the list myself. > > Reviewed-by: Chad Versace <chad.vers...@intel.com>
Oops, I just saw airlied's patch. I prefer airlie's approach because it prevents future bugs arising from similiar misuse of _mesa_get_format_bytes(). I think that if we rely on an explicit cast here, in the future someone will forget to do the cast and this bug will reappear. -- Chad Versace c...@chad-versace.us _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
