Am 03.05.2011 15:55, schrieb Marek Olšák: > Hi, > > the first patch adds AMD_seamless_cubemap_per_texture to Mesa. > > The second patch adds support for both seamless_cube_map extensions to > Gallium. The motivation for this particular implementation is to make driver > code as simple as possible. > > A Gallium driver can support either of these two CAPs: > - PIPE_CAP_SEAMLESS_CUBE_MAP: the driver should follow > pipe_rasterizer_state::seamless_cube_map. > - PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE: the driver should follow > pipe_sampler_state::seamless_cube_map. > Both CAPs cannot be exposed at the same time. The reason for this is that > there is no hardware which supports both. > > There are new piglit tests for both extensions. > > Please review. > > > Marek Olšák (2): > mesa: implement AMD_seamless_cubemap_per_texture > gallium: implement seamless cubemap extensions > > src/gallium/include/pipe/p_defines.h | 2 + > src/gallium/include/pipe/p_state.h | 2 + > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 2 + > src/mesa/main/texobj.c | 2 + > src/mesa/main/texparam.c | 32 > +++++++++++++++++++++++++++ > src/mesa/state_tracker/st_atom_rasterizer.c | 6 ++++- > src/mesa/state_tracker/st_atom_sampler.c | 3 ++ > src/mesa/state_tracker/st_extensions.c | 9 +++++++ > 9 files changed, 58 insertions(+), 1 deletions(-) >
This looks ok to me if only half elegant. Please update the relevant sections in the gallium docs, though (screen, cso/sampler, cso/rasterizer probably). Roland _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
