On Tue, Apr 26, 2011 at 4:57 PM, Brian Paul <bri...@vmware.com> wrote:
> On 04/26/2011 04:57 AM, Marek Olšák wrote: > >> Hi, >> >> this series implements GL_EXT_texture_shared_exponent. >> >> The file rgb9e5.h has all its functions inline, because it's shared >> between classic and gallium. In that file, there are functions >> rgb9e5_to_float3 and float3_to_rgb9e5, which are used pretty much >> everywhere. >> > > I think I'd opt to put the code for this in gallium/util and include it in > Mesa with a wrapper header. In the future I think we're more likely to use > additional Gallium utility code in Mesa than vice versa. Will do. > > > I usually do some hardware support and the driver of my choice was >> so far r300g. Because r500 hw can't do this extension, I am adding >> support to r600g instead. >> >> There is swrast, softpipe, llvmpipe, and r600g support. There is no >> renderbuffer support, because r600 can't do it and the spec doesn't >> require it anyway. (I guess it wasn't meant to be used as a >> renderbuffer) >> >> Please review. >> > > Reviewed-by: Brian Paul <bri...@vmware.com> > > Were you going to make a piglit test too? > There are these tests: ./fbo-generatemipmap-formats GL_EXT_texture_shared_exponent ./texwrap GL_RGB9_E5 And yesterday I updated glean/pixelFormats to test this extension as well. Marek
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
