On Tue, 12 Apr 2011 15:42:06 -0700, Kenneth Graunke <kenn...@whitecape.org> 
wrote:
> Since we never enable the GS on Sandybridge, there's no need to allocate
> it any URB space.
> 
> Furthermore, the previous calculation was incorrect: it neglected to
> multiply by nr_vs_entries, instead comparing whether twice the size of
> a single VS URB entry was bigger than the entire URB space.  It also
> neglected to take into account that vs_size is in units of 128 byte
> blocks, while urb_size is in bytes.
> 
> Despite the above problems, the calculations resulted in an acceptable
> programming of the URB in most cases, at least on GT2.
> 
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>

The logic all looks good to me.

Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: pgpb0RJC1ImZc.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to