> In this change you've got an int value (copy_size) which has some > special meaning when negative -- can you add comments explaining what > the meaning of a negative size is? Is there a way to use some more > explicit flag value to indicate this condition?
I think it makes sense, since -1 stands for "not applicable", because we aren't doing the memcpy whose size copy_size is about (also, the CPU will already have the value loaded for use in memcpy if it turns out to be non-negative). I added a comment explaining that. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev