https://bugs.freedesktop.org/show_bug.cgi?id=29407
nobled <nob...@dreamwidth.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #37651|0 |1
is obsolete| |
--- Comment #15 from nobled <nob...@dreamwidth.org> 2010-08-08 13:19:54 PDT ---
Created an attachment (id=37704)
View: https://bugs.freedesktop.org/attachment.cgi?id=37704
Review: https://bugs.freedesktop.org/review?bug=29407&attachment=37704
gallivm: Always use floating point operators for floating point values (v4)
(In reply to comment #14)
> Created an attachment (id=37702)
--> (https://bugs.freedesktop.org/attachment.cgi?id=37702)
> Use fneg instead of neg when inverting the sign of floats
[snip]
> The fact is that more instructions than add, sub, mul and div need their float
> counterpart. My patch fixes two "neg" instructions in lp_bld_tgsi_soa.c. It
> was
> the fix I needed to be able to run Neverball. I will now see if there are more
> places where an instruction needs to be replaced with its float counterpart,
> but I need to find GL programs that use them. Maybe piglit can help me.
>
Awesome, thanks! (damn barely-mentioning-fneg-at-all release notes...)
I grep'd for all the other instances of LLVMBuildNeg-- updated patch attached
(includes yours, with credit and some modifications).
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
