Owain Ainsworth wrote:
On Mon, Apr 19, 2010 at 07:34:04AM +0200, Matthieu Herrb wrote:
On Sun, Apr 18, 2010 at 05:03:51PM -0700, Jeremy Huddleston wrote:
This one looks broken...
#if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= 4)
(__GNUC__ == 3 && __GNUC__ >= 4)
you forgot _MINOR...
And I think your '__GNUC_MINOR__ >= 3' might need to be >= 4
Yes, sorry. My first thought was that those builting were gcc 4 only
and I wrote and tested patches with only the __GNUC__ >= 4 test.
Then I found out that gcc 3.4 also have them and quickly modified my tests.
I managed to make one mistake per chunk !.
the commit below to my tree fixes them.
I can respin this series (with this squashed into patch 4), or we can
just tack this on onto the end of it. Whatever is preferred.
I'll combine the patches and commit them. Thanks.
-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev