[ 
http://opencast.jira.com/browse/MH-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32856#comment-32856
 ] 

Eduardo Alonso commented on MH-9309:
------------------------------------

As long as I'm not able to create a review, I do it here:

1. This is a regression, the strings in the array specifies which workflow 
definitions are loaded with this tags
ocWorkflow.init($('#workflowSelector'), $('#workflowConfigContainer'), 
['schedule']); // before merge
ocWorkflow.init($('#workflowSelector'), $('#workflowConfigContainer')); // 
after merge

You are right. I missed that part when I modified the UI. Ruben will commit a 
patch right now.


2. The xml namespace for dublin core catalogs isn't used, possible regression.
id = data.getElementsByTagName('dcterms:identifier')[0].textContent; // before 
merge
id = data.getElementsByTagName('identifier')[0].textContent; // after merge

If you include the namespace you can not find the data. I think that the 
namespace is assumed implicitly


3. I'm not sure why the templates are outsourced to shared-resources, as far as 
I know they will just used by the admin UI, aren't they?

The are used by the admin UI and the Trim operation handler.


4. In the old implementation the license field was an empty input field, now it 
is a select, how are we able to add additional license fields?

It was a select in the trim operation handler so I decided to keep that one. 
Also Judy used a select in her schedule UI mockup: 
http://opencast.jira.com/wiki/display/MH/Schedule+Recording+--+Workflow+Dependent%2C+Multiple+Metadata+Catalogs
                
> Some info does not show in 'View Recording Info'
> ------------------------------------------------
>
>                 Key: MH-9309
>                 URL: http://opencast.jira.com/browse/MH-9309
>             Project: Matterhorn Project
>          Issue Type: Bug
>          Components: Administrative Tools
>    Affects Versions: 1.4
>            Reporter: Eduardo Alonso
>            Assignee: Eduardo Alonso
>            Priority: Release Blocker
>             Fix For: 1.4
>
>         Attachments: Do not show information.png, MH-9309.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://opencast.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Matterhorn mailing list
Matterhorn@opencastproject.org
http://lists.opencastproject.org/mailman/listinfo/matterhorn


To unsubscribe please email
matterhorn-unsubscr...@opencastproject.org
_______________________________________________

Reply via email to