+1, since broken revisions aren't acceptable. When a committer rolls back a commit from someone else, is he supposed to notify that respective person?
Christoph Am 20.09.2011 um 22:01 schrieb Rubén Pérez: > +1 as long as integration tests are fixed. I was one of the "rogue" > developers who didn't run integration tests. I did it today and most of them > failed. I'm assuming some of the tests are wrong and that, after they are > fixed, the "Wunden Ultimatum" will be fully applied. > > 2011/9/20 Christopher Brooks <[email protected]> > +1 > > If we keep our tests going then QA is going to start getting much > easier! > > Chris > > On Tue, 20 Sep 2011 18:23:43 +0200 > Tobias Wunden <[email protected]> wrote: > > > Dear committers, > > > > you are probably aware of the fact that integration tests are broken > > both for 1.2 as well as for 1.3 (trunk). If you are not, and you are > > a committer, you should immediately take a look at [1], which > > explains what integration tests are and how they are executed. > > > > At today's meeting, we agreed to fix the integration tests both for > > trunk and 1.2.1. I will take the lead and make sure it happens, > > people who are doing the merges from 1.2.x to trunk are invited to > > help. > > > > As the most important outcome from this meeting, people have > > expressed their willingness to roll back code changes that break > > integration tests without further warning or grace periods. Code > > cannot be committed to trunk if it breaks unit or integration tests > > and must therefore be rolled back by the first committer to notice > > it. This is not new, and running the integration tests prior to > > committing has always been a requirement. However, we as a project > > have started to accept broken integration tests, and once you start > > doing this, nobody cares anymore. > > > > We therefore propose: > > > > Committers *must* run both unit and integration tests before they > > commit Committers *must* roll back commits that break either one of > > the test suites > > > > Tobias > > > > [1] http://opencast.jira.com/wiki/display/MH/Integration+Tests > > _______________________________________________ > > Matterhorn mailing list > > [email protected] > > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > > > > To unsubscribe please email > > [email protected] > > _______________________________________________ > > > > -- > Christopher Brooks, BSc, MSc > ARIES Laboratory, University of Saskatchewan > > Web: http://www.cs.usask.ca/~cab938 > Phone: 1.306.966.1442 > Mail: Advanced Research in Intelligent Educational Systems Laboratory > Department of Computer Science > University of Saskatchewan > 176 Thorvaldson Building > 110 Science Place > Saskatoon, SK > S7N 5C9 > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________ > > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
