Hi, Sergei, Jan, I have already approved the InnoDB changes.
On Sat, Dec 19, 2020 at 12:43 PM Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Jan! [snip] > > + mysql_mutex_lock(&LOCK_thd_kill); > > + mysql_mutex_unlock(&LOCK_thd_kill); > > Note that THD destructor starts from `assert_not_linked()` - > it's important, because if the THD is linked in the list of threads, > then someone might start using it after you released LOCK_thd_kill. > > With the new logic you need to move assert_not_linked to > free_connection(). > > otherwise ok to push Do you mean that also the empty mutex lock/unlock pair should be removed from THD::~THD()? It was copied (not moved) from there in this patch. Marko -- Marko Mäkelä, Lead Developer InnoDB MariaDB Corporation _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
