tandon updated this revision to Diff 10425. tandon marked an inline comment as done. tandon added a comment.
Clipper was not able to merge some of the adjacent buildings (buildings which only share one common point), to circumvent this problem, I made a few changes in the way in which the edges of the building graph were contracted. Instead of treating the connected components of buildings as connected graphs, I am now treating them as trees, so as to prevent any kind of cyclic dependency b/w buildings. Doing this allows me to easily break a connected component into two or more connected components whenever clipper is not able to merge two adjacent buildings. This trick is able to greatly improve the results but still there are a few error cases. REPOSITORY R34 Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3747?vs=9194&id=10425 REVISION DETAIL https://phabricator.kde.org/D3747 AFFECTED FILES tools/vectorosm-tilecreator/BuildingBlock.cpp tools/vectorosm-tilecreator/BuildingBlock.h tools/vectorosm-tilecreator/BuildingMerger.cpp tools/vectorosm-tilecreator/BuildingMerger.h tools/vectorosm-tilecreator/CMakeLists.txt tools/vectorosm-tilecreator/vectorosm-tilecreator.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: tandon, rahn, nienhueser Cc: nienhueser, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, marble-devel
