----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126213/#review88998 -----------------------------------------------------------
examples/cpp/hello-marble/CMakeLists.txt (line 5) <https://git.reviewboard.kde.org/r/126213/#comment60921> This looks like some leftover from a previous merge/stash examples/cpp/hello-marble/CMakeLists.txt (line 30) <https://git.reviewboard.kde.org/r/126213/#comment60922> This looks like a leftover - actually I wonder whether the whole changes of the CMakeLists.txt are supposed to be part of this changeset. src/lib/marble/osm/OsmPresetLibrary.cpp (line 268) <https://git.reviewboard.kde.org/r/126213/#comment60923> you might need to add s_visualCategories[ OsmTag( "tourism", "picnic_site" ) ] = GeoDataFeature::LeisurePicnicTable; as well :) src/lib/marble/osm/OsmPresetLibrary.cpp (line 543) <https://git.reviewboard.kde.org/r/126213/#comment60924> See above ... - Torsten Rahn On Dez. 1, 2015, 10:23 vorm., Raphael Cojocaru wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126213/ > ----------------------------------------------------------- > > (Updated Dez. 1, 2015, 10:23 vorm.) > > > Review request for Marble and Dennis Nienhüser. > > > Repository: marble > > > Description > ------- > > I added a new entry for the picnic table icon in GeoDataFeature.cpp file. > I followed the "LeisurePlayground" example and created my > "LeisurePicnicTable". > I also modified GeoDataFeature.h and OsmPresetLibrary.cpp. > > > Diffs > ----- > > examples/cpp/hello-marble/CMakeLists.txt 0150782 > src/lib/marble/geodata/data/GeoDataFeature.h 0ed1fce > src/lib/marble/geodata/data/GeoDataFeature.cpp 196922f > src/lib/marble/osm/OsmPresetLibrary.cpp 5e1b6ba > > Diff: https://git.reviewboard.kde.org/r/126213/diff/ > > > Testing > ------- > > > Thanks, > > Raphael Cojocaru > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
