----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116525/#review61782 -----------------------------------------------------------
src/lib/marble/RemoteIconLoader.h <https://git.reviewboard.kde.org/r/116525/#comment43001> const QByteArray &, const QString & note the & for passing as a reference - Dennis Nienhüser On July 7, 2014, 4:03 a.m., Abhinav Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116525/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 4:03 a.m.) > > > Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, > and Thibaut Gridel. > > > Bugs: 310464 > http://bugs.kde.org/show_bug.cgi?id=310464 > > > Repository: marble > > > Description > ------- > > The patch adds support to download remote images > > > Diffs > ----- > > src/lib/marble/VisiblePlacemark.cpp 8811598 > src/lib/marble/geodata/data/GeoDataIconStyle.h 8838e49 > src/lib/marble/geodata/data/GeoDataIconStyle.cpp 6902fcf > src/lib/marble/CMakeLists.txt a016307 > src/lib/marble/PlacemarkLayout.cpp 408607b > src/lib/marble/RemoteIconLoader.h PRE-CREATION > src/lib/marble/RemoteIconLoader.cpp PRE-CREATION > src/lib/marble/VisiblePlacemark.h 5356f4d > > Diff: https://git.reviewboard.kde.org/r/116525/diff/ > > > Testing > ------- > > Works fine on my system > > > Thanks, > > Abhinav Gangwar > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
