>>>Hi >>> >>>I'm still trying to close mantis issues by committing changes >>>with a matching "Fixed" message. The changeset is imported >>>but the issue is not closed. >> >>My memory was letting me down. Seems like we already had >>this problem years ago and I also asked on the mailing list: >> >>https://sourceforge.net/p/mantisbt/mailman/mantisbt-help/thread/20171107095422.061FD31FBDC1%40macserver.private >> >>Then I left a code change on github: >> >>https://github.com/mantisbt-plugins/source-integration/issues/229 >> >>I now applied the same patch to the current version in hopes >>of getting the behavior back that we were used to. >> >>Is there a reason why that shouldn't be applied to the official >>code as well? I find it misleading that the option "Bug Fixed >>Assign To Committer" unchecked will completely disable >>closing of issues. Right now it rather behaves like the "Enabled >>Features" box to close issues. > >The current behavior is by design actually (see ><https://github.com/mantisbt-plugins/source-integration/issues/80>#80), as >documented in the code: > ><https://github.com/mantisbt-plugins/source-integration/blob/e374feca48ddfce87b7d34a628dc370b01e197ba/Source/Source.API.php#L380-L382>https://github.com/mantisbt-plugins/source-integration/blob/e374feca48ddfce87b7d34a628dc370b01e197ba/Source/Source.API.php#L380-L382 > >I did not look in detail to confirm for sure, but if I'm not mistaken what ><https://github.com/fcenedese>@fcenedese suggests would allow resolved issues >not to be assigned at all, which feels strange to me. What do you think ? > >Anyway, I'll have a closer look as time allows.
I just think that the naming of this option doesn't match its function. Right now it just says "assign name", but unchecking it disables issue closing completely. So it does (almost?) the same as the feature box. I find this counter intuitive. If you use my code change and enable the "assign name" box by default then you get the same behavior as it is now I think. However disabling it allows to close an issue without changing the assignee which is not possible right now. If that means that an issue might be closed without a user assigned to it then so be it, that's why we unchecked this feature. Usually we already assigned the issues beforehand so they already have an assignee. And if the issue is closed by a commit then it's also visible who did the commit. The assignee does not need to be the same as the one fixing/closing the issue. Of course you can keep the current behavior but then at least you need to change the wording of the check box as it definitely doesn't describe its function right now. And we'd still keep our local mantis patched to get the desired functionality. But looking at the comments in the issues and mailing lists we're not the only ones struggling with this. Thanks bye Fabi _______________________________________________ mantisbt-help mailing list mantisbt-help@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mantisbt-help
