>i added some debug code to see what's going on. I found out
>that Source.API.php checks for PVM and skips the closing
>if this is not available and enabled. PVM is the product-version-
>matrix plugin. Why is this needed? Can't I just close bugs in
>mantis without this plugin? Is it enough to just install and enable
>it or does it have more dependencies? Does it need configuration
>if I don't use it?

Even though I'm only talking to myself here: I think I now found
the real problem, nothing to do with PVM. There's a setting stored
in the database under 'plugin_Source_bugfix_handler'. In the config
page this is the option 'Bug Fixed Assign To Committer'. I unchecked
this because I didn't want to change any data in the bug, I only want
it to be closed if the commit message contains 'Fixed #...' That's when
the automatic closing stopped.

In Source.API.php this variable is checked if it is set.

$t_handler = config_get( 'plugin_Source_bugfix_handler' );
if ( Source_PVM() ) {
...
} elseif( $t_handler && $t_handler_id !== null ) {
...close bug
}

So it seems that auto closing is not possible if this setting is not
enabled. As I don't want to change the handler in the bug I will either
skip the check for the setting or disable the code to change the bug
handler. I find it wrong to disable closing completely if this handler
is not set in the config. And it looks like the current code in git is
still the same.

Are there reasons to do it like that? Am I missing something?

Thanks

bye  Fabi


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
mantisbt-help mailing list
mantisbt-help@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-help

Reply via email to