> On Sep 27, 2021, at 9:07 AM, Sergey A. Osokin <o...@freebsd.org> wrote: > > Hi folks, > > On Fri, Sep 24, 2021 at 02:33:34PM -0500, Marius Schamschula wrote: >> Sergey, >> >> I’ve edited those parts: > > is there any other suggestions or comments on the www/unit/Portfile?
In the absence of feedback from people much more knowledgable than me... Am I missing something obvious? Should there not be supports for the various versions of Perl, Python and Ruby? IE unit-python39 instead of unit-python? Shouldn’t each support depend on the relevant version of the support module. Eg unit-python39 should depend on python39 ? Can different versions coexist or must they be marked as conflicting? Eg can unit-python38 and unit-python-27 be installed at the same time? Is there some reason that you are not adding module support for PHP, Go, Java and Node.js? Should the unit port not depend on nginx? Or is it that the nginx server can be on another machine? Perhaps a default variant should be added that simply adds a run dependency on nginx as a courtesy to new users? Is the unit port, by itself, capable of anything useful? Doesn’t at least one of the subports need to be installed? If so, I think you should add notes to indicate this. The notes might also direct the user to an appropriate web page regarding configuration. Craig
