> On Dec 22, 2016, at 03:31, Vincent <vi...@macports.org> wrote:
>
> Vincent (Veence) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/45b2e591b885eba86e4dc85d19f0608a35fa9520
>
> The following commit(s) were added to refs/heads/master by this push:
>
> new 45b2e59 grass7: add more patches (__unix__ -> __APPLE__)
>
> 45b2e59 is described below
>
>
> commit 45b2e591b885eba86e4dc85d19f0608a35fa9520
>
> Author: Veence <vi...@macports.org>
> AuthorDate: Thu Dec 22 10:30:04 2016 +0100
>
>
> grass7: add more patches (__unix__ -> __APPLE__)
>
> ---
> gis/grass7/Portfile | 17 +++++-
> gis/grass7/files/patch_libraster-gdal_c.diff.tplt | 67
> +++++++++++++++++++++++
> 2 files changed, 82 insertions(+), 2 deletions(-)
>
>
> diff --git a/gis/grass7/Portfile b/gis/grass7/Portfile
> +pre-patch {
> + exec sed -e s#&&&#${prefix}# \
> + ${filespath}/patch_libraster-gdal_c.diff.tplt > \
> + ${worksrcpath}/patch_libraster-gdal_c.diff
> + exec patch -p0 -d ${worksrcpath} <
> ${worksrcpath}/patch_libraster-gdal_c.diff
> +}
Is there a reason why you use "exec" here instead of what we usually use:
"system"?
> + # Substitute __unix__ by __APPLE__
> + set c_files [exec find ${worksrcpath} -name *.\[ch\]]
> + puts $c_files
> + foreach f $c_files {
> + reinplace "s|__unix__|__APPLE__|" $f
> + }
I assume this "puts" is debugging code which should be removed.
We would prefer you use Tcl code, including the fs-traverse procedure, rather
than executing external programs like "find".
