It helps. If PR is outdated and then you do git pull from maser instead of rebasing on top of it and force push into your branch you'll see all this duplicated commits in the PR.
And it has nothing to do with clicking any buttons. I'm taking about reviewing PR and not about merging it. You can merge in whatever way you want, it doesn't cancel the fact that PR is a great thing to review difference between proposed change and master. I can't count amount of times when I found typo or bug in my own PR just because I took another look at it from github web interface pretending that I'm reviewing someone's else change. > On Dec 21, 2016, at 11:25 PM, Mojca Miklavec <mo...@macports.org> wrote: > >> On 21 December 2016 at 22:38, Ivan Larionov wrote: >> One of the ways to avoid it is to review things you're going to merge. And >> one of the easiest ways to do it is to open a PR on github where you can >> clearly see which commits you're going to merge. > > That doesn't necessarily help. The author can submit a pull request > which will get outdated by the time it gets committed – leading to > exactly the same problem at the end. > > And clicking the button on the PR introduces the annoying wrong > committer email address. > > Mojca
