On 07 Nov 2016, at 17:55 , Lawrence Velázquez <lar...@macports.org> wrote:
> I think the objection to #7 is that it was intentionally posted in an > incomplete state with the expectation that development would continue in > the pull request. I am not sure that that is the best approach for us. TBH I had hoped that it wasn’t that incomplete at the time of posting... > When I said that committers should feel free to open PRs, I meant PRs > for contributions that are essentially complete and might just need > a bit of tweaking. Well, if you look at the tweaks which have been done since submitting it I’d rather say it needed only a bit of tweaking itself. No? So? :-) One rarely knows the answer before uttering a question… Please comment on the PR if you have any objections, otherwise I’ll go ahead with committing a squashed version of it once I got the pending tests of its various variants successfully done, if that’s okay.
