Eric Blake <[EMAIL PROTECTED]> wrote:
> Here's what I installed on the argv_ref branch instead - it likewise shows
> an impressive speedup, even without implementing memchr2 or using
> freadahead yet (but those two steps can only help), and it will be much
> easier to port to the master branch. Thanks again for reporting this hot
> spot in execution, and forcing me to come up with a nicer way to optimize it.
>
> http://git.sv.gnu.org/gitweb/?p=m4.git;a=commitdiff;h=7468916
Hi Eric,
In the above, I noticed this:
+ while (1)
+ {
+ size_t len;
+ const char *buffer = next_buffer (&len, false);
+ if (buffer)
+ {
+ const char *p = (char *) memchr (buffer, '\n', len);
That cast looks unnecessary -- unless you care about C++ compilers.
_______________________________________________
M4-discuss mailing list
M4-discuss@gnu.org
http://lists.gnu.org/mailman/listinfo/m4-discuss
