Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > [EMAIL PROTECTED] writes: | > | > | Author: baum | > | > | Date: Mon Sep 4 16:43:25 2006 | > | > | New Revision: 14890 | > | > | | URL: http://www.lyx.org/trac/changeset/14890 | > | > | Log: | > | > | Fix byte order problems | > | > | * src/support/unicode.C | > | > | (bytes_to_ucs4): make it work on big endian machines | > | > | (bytes_to_ucs2): make it work on little endian machines | > | > | (ucs2_to_ucs4): ditto | > | > | (utf8_to_ucs4): Invoke iconv with explicit BE suffix | > | > | (ucs2_to_ucs4): ditto | > | > | (ucs4_to_ucs2): ditto | > | > | (ucs4_to_utf8): ditto | > | > Is this really what we want? | > | > (The answer from my pov is "NO") | > | > IMHO we want to use native endianess internally, and I do not get why | > | > anything should care about what we do internally.\ | > | | AFAIU that's exactly what Georg' patch is doing: making sure | > that we | > | use the native endianess internally regardless of iconv potential | > | ambiguity. | > The log says "with explict BE suffix", so I assumed that to be the | > case. | | The log says "_Invoke_ _iconv_ with explicit BE suffix" that's quite | different.
but why.... I would have assumed that using LE resp. BE and drop all later byteswapping would have been the way to go... -- Lgb