Georg Baum wrote:
Abdelrazak Younes wrote:
Georg Baum wrote:
Yes. You store now the data twice, and it is not synchronised.
If you mean data_ and QLyXKeySym, it was like this before, I am just
mapping functionalities with the old code. Port first, cleanup second.
If you mean argument and data_, then no, nothing is stored in arument
anymore.
Yes, I mean argument and data_. Maybe nothing is stored for that particular
lfun in argument anymore, but others do still use argument.
You did not change getArg(), and you also forgot to adjust operator==.
I did not forgot anything. I created data_ as an evolutionary member. I
did not touch at all the other uses of argument. The LFUN_SELF_INSERT
insert doesn't use getArg() it uses data(). As for operator==, it was
not useful for this particular patch. I have been told one patch, one
change...
Adhoc
changes like that are calling for bugs.
It appears that we are only two working on this so I don't think so.
But your patch seems to do the full monty...
Abdel.
