>>>>> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:

>> - in MathScriptInset::notifyCursorLeave, there were no
>> recordUndoInset calls. This fix seems safe and obvious to me

Andre> Worst case scenario is that an additional C-z is needed to undo
Andre> stuff. Could be mildly annoying if it is (not sure it is...)
Andre> but would certainly acceptable to fix a crash.

One case that would produce two undos is to use middle mouse click to
paste somewhere in the inset (or in the document) when the cursor is
in an empty inset.

I do not think this is a big problem.

Andre> Saving a document is changed. Try a round trip with empty
Andre> cells. The potential of damage is low in any case as empty
Andre> scripts can be read back correctly. Might be even a good move
Andre> in general.

Save/reload seems to work fine.

>> An alternative would be to add a keepempty member to WriteStream,
>> which would be set to true when in asString.

Andre> Sounds more difficult and fragile.

Yes.
 
JMarc

Reply via email to