Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> OK, now I understand the problem, sorry for my autism ;-).
Abdelrazak> Then the fix is even simpler for this particular dialog:
Abdelrazak> just transfer the code in update_contents() to
Abdelrazak> buil_dialog(). In any case, the error list will be
Abdelrazak> automatically updated if a new error list is generated. Or
Abdelrazak> am I missing something again?

I think it will not work if you generate the error list a second time.
As I wrote, build is only invoked at the initial creation of the dialog.

Indeed. We could ask QErrorList to re-instantiate the dialog... But what about this simpler patch instead? The dialog will not remember its last position but this can be implemented easily.

The reason why I am insisting is because a change in the controller to accomodate a dialog doesn't feel right. For qt4, doing the model/view separation (as in the Citation and Toc dialogs) will solve the problem.

Abdel.

Reply via email to