Georg Baum wrote:
Abdelrazak Younes wrote:

I will commit to my branch to let Lars the time to review this patch. I
hope he will not be upset to have multiple fix in the same branch.

I fear he will, because this has nothing to do with the other stuff in your
branch.

It has because it is only triggered with my BufferView changes. But really, I think it is a perfect illustration of the failure of the current commit procedure. With a distributed SCM (git, mercurial, etc) my current practice would be encouraged. I cannot at the same time do very small patches so that everyone can understand and wait tomorrow for committing to trunk and then merging trunk with my branch.

If I were you I would announce that this patch will go in trunk tomorrow
unless there are objections. This is a perfect example for this procedure:
It is an obvious bug fix with a very small chance that somebody does not
like it, so the default should be to go in trunk.

I know but I need it now. I don't want to wait tomorrow. I will commit to trunk the two bug fixes tomorrow.

In addition I would also ask Jean-Marc if he wants it for 1.4 (in case it is
applicable, I did not check).

I guess not, otherwise it would have shown earlier.

Abdel.

Reply via email to