Angus Leeming wrote:
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:
It's much better to make 10 commits during 3 hours. Then each diff is
manageable in a review, and it is technically easier to revert.
Lars has a point that it can improve your workflow when you need to
think small, self-contained steps. But this effect can be achieved
without a patch review system.
I don't think that there's too much wrong with the present system. What seems to
be lacking --- and what leads to the frustration --- is that patch review has
turned into "thou shalt not commit until *I* am happy" (for some *I*). I'd
prefer to see an environment in which people felt comfortable committing
"imperfect" code so long as they also accepted that the flip side of this
privilege was that they addressed these criticisms. Sometimes that would mean
fixing the code. Sometimes it would mean defending what they've written ;-)
Now that Lars has installed Trac, commit mails sent out automatically by lyx-cvs
all have hyperlinks to the changes. Given that giving individuals commit rights
to the repository implies a certain level of trust, it makes perfect sense to me
to allow people to work as Asger suggests but to expect them to drop a line to
lyx-devel saying what they've done:
Hey guys, I've just committed Tomaz's update to pl.po to the 1.4 branch. See
http://www.lyx.org/trac/changeset/14334
http://www.lyx.org/trac/changeset/14335
The rest of us are then free to comment as we do now --- and should expect the
committer to pay due regard to these comments.
Angus, that seems like a perfect plan to me. I am going to follow this
very logic from now on.
FYI, the main reason why my patches contained more that one "logical
change" is that I was bitten more than once by the lengthy review
process and I thought that Lars opinion was "gospel". If I read the
messages from Lars, it seems that everything was in my head and that I
probably need to see the doctor ;-)
That said, if I read Asger, Helge or Andre correctly, it seems that my
mental disease is not that strong at the end :-)
Anyway, I think it's very good that the commit and review process is now
agreed by everyone. It was a very interesting debate to read :-)
So, many thanks to all and please let me the honor to put a final dot at
this discussion:
dot.
Abdel.
PS: I was in Lisboa (Lisbon, very nice city) for the last three days and
I saw in live the sadness of Portuguese yesterday night. Sorry Jose ;-)
