Georg Baum wrote:
> I see that you used validators for unsigned lengths. I agree that this is
> the normal case, but maybe it should be possible to insert a negative
> length in special cases?
Right, I didn't think about that.
> > OK to apply?
>
> Yes, but I have some comments:
>
> + if (!form_->bc().bp().isReadOnly()) {
> + topspaceED->setEnabled(false);
> + topspaceUnit->setEnabled(false);
> + }
>
> The if is not needed here.
Indeed.
> + connect(topspaceCO, SIGNAL( activated(int) ), this,
> SLOT(topspace_changed()));
>
>
> I think our spacing rules say
>
> + connect(topspaceCO, SIGNAL(activated(int)), this,
> SLOT(topspace_changed()));
OK. I'll correct this in the cotext as well (Abdel, you're reading this?).
> - <tabstop>topspaceED</tabstop>
> - <tabstop>topspaceUnit</tabstop>
> - <tabstop>bottomspaceED</tabstop>
> - <tabstop>bottomspaceUnit</tabstop>
> - <tabstop>interlinespaceED</tabstop>
> - <tabstop>interlinespaceUnit</tabstop>
>
> Why are the new widgets not listed?
I missed that.
I corrected the issues and will commit now.
Jürgen
> Georg
