Georg Baum wrote:
Am Donnerstag, 15. Juni 2006 12:39 schrieb Abdelrazak Younes:
Hello,
Minus potential compilation problems with gtk and/or xforms I think I am
ready to merge my branch with trunk. Please find attached the complete
patch. I will wait for some green lights before applying.
I scanned the patch and found some formatting issues: umlauts and
whitespace. Some are fixed by the attached patch. I also noticed that
there is only one line between methods in some files in qt4, we use 2
(but this is like that in trunk, too).
The patch also fixes the line ending functions. I removed the #ifdefs in
internalLineEnding() so that it could also be sued to e.g. read a windows
file on linux.
I'd like to put it in your branch. OK?
This looks good to me. Please go ahead.
The rest is fine with me but in this case you should wait for more
comments.
Yes, I will wait for some more. But I guess I won't have any because
except for the namespace issue nobody (except you and Angus) gave any
substantial objection. It seems that this work is not as controversial
as I thought it would be ;-)
Thanks,
Abdel.
