Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> IMHO the only thing to do before merging to trunk is to
Abdelrazak> agree on the namespace issue. I like Angus idea that
Abdelrazak> namespaces are named after directories.
I agree that this is a very reasonable convention for namespace.
Abdelrazak> Lars, Jean-Marc please express your opinions.
I have to admit I did not follow this thread very well. One trivial
thing that I do not like much is that cursor() is not an LCursor as it
is throughout the rest of the code. Could we find a better name?
I thought about GuiCursor but ended up with cursor because that's what
it is. Actually I would like that to rename Cursor but then there would
be a clash between Cursor.h and cursor.h under windows. cursor.[Ch]
should probably renamed to LCursor.[Ch]... shall I do that?
Just for opening the debate, as you asked me ;-), I think LCursor is the
one not properly named. Verbatim from the source:
/// The cursor class describes the position of a cursor within a document.
// The public inheritance should go in favour of a suitable data member
// (or maybe private inheritance) at some point of time.
class LCursor : public DocIterator {
I think CursorIterator or CursorContext would be better names than LCursor.
But as I said I can rename cursor() to guiCursor() if you prefer it this
way. I just wanted to expose all the issues ;-)
Abdel.
