Abdelrazak Younes wrote: > Very good Peter! So we don't need the shared_ptr in WorkArea then?
No, this would only be a hack. >> And here are some cleanups: >> >> - setQPainterPen needs not to return its parameter QPainter& > > Good, note that in my QPainter cache try, I transformed this > setQPainterPen into a "QPainter * getQPainter(...)". Please find > attached an outdated patch (that won't apply) if you want to continue > this work. Will have a look at it. >> - split painting commands into two lines > > Agreed. > >> - color is 'col' >> - use operator[] > > OK. > > Please commit to "trunk" and... Do you think I could commit it now, or should I wait for more comments? > to "younes" if you want be kind with me ;-) Already prepared :) Peter
