[EMAIL PROTECTED] writes:

| Index: frontends/qt3/lyx_gui.C
| ===================================================================
| --- frontends/qt3/lyx_gui.C   (revision 14083)
| +++ frontends/qt3/lyx_gui.C   (working copy)
| @@ -222,12 +222,12 @@
|  
|  
|  void start(string const & batch, vector<string> const & files,
| -        unsigned int width, unsigned int height, int posx, int posy)
| +        unsigned int width, unsigned int height, int posx, int posy, bool 
isMax)

Is 'isMax' a good name?

'maximize' seems better to me.

| Index: frontends/qt3/QtView.C
| ===================================================================
| --- frontends/qt3/QtView.C    (revision 14083)
| +++ frontends/qt3/QtView.C    (working copy)
| @@ -55,10 +55,13 @@
|  
|  
|  
| -QtView::QtView(unsigned int width, unsigned int height)
| +QtView::QtView(unsigned int width, unsigned int height, bool isMax)
|       : QMainWindow(), LyXView(), commandbuffer_(0)
|  {
|       resize(width, height);
| +     
| +     if(isMax)
| +             this->setWindowState(WindowMaximized);

Missing space after 'if'

|  
|       qApp->setMainWidget(this);
|  
| @@ -160,6 +163,9 @@
|  
|  void QtView::closeEvent(QCloseEvent *)
|  {
| +     LyX::ref().session().saveSessionInfo("WindowIsMaximized", 
(this->isMaximized() ? "yes" : "no"));
| +     //don't save maximized values

Missing space after '//'

Introductin a local var (tmp ref) for LyX::ref().session() might also be
in order.

| Index: frontends/qt4/QtView.C
| ===================================================================
| --- frontends/qt4/QtView.C    (revision 14083)
| +++ frontends/qt4/QtView.C    (working copy)
| @@ -70,11 +70,14 @@
|  } // namespace anon
|  
|  
| -QtView::QtView(unsigned int width, unsigned int height)
| +QtView::QtView(unsigned int width, unsigned int height, bool isMax)
|       : QMainWindow(), LyXView(), commandbuffer_(0)
|  {
|       resize(width, height);
|  
| +     if(isMax)
| +             this->setWindowState(Qt::WindowMaximized);
| +

(spacing)

-- 
        Lgb

Reply via email to