Georg Baum wrote:
Am Montag, 5. Juni 2006 13:50 schrieb Abdelrazak Younes:
Except for the crash on exit problem, could you confirm me that the
clipboard functionality remains the same for linux/X11/qt3/xforms/gtk?
I did not try, and would rather not like to test this obsolete patch
further, but a future one that has the remaining problems solved. If you
have a clear idea how it should look like I don't see any reason why it
could nto be made work on all frontends.
OK.
This is again something I don't care too much, but I think it will be
accepted if you either do the changes in all frontends or give clear
instructions what needs to be done.
That's the plan yes.
Comments, opinion?
Both variants would be fine with me.
OK.
I agree that multiple inheritance of non base classes should be avoided.
But, in my opinion, polymorphism thanks to inheritance of multiple base
virtual classes is a very nice concept that should be used.
This makes sense e.g. for QWorkArea that is both a QWidget and a Workarea,
but adding Clipboard to that is IMO a hack that should be avoided.
But it is my point that WorkArea are not clipboard and yet they are used
as clipboard for all frontends but qt4 (in my tree)!
That said, conceptually speaking, there is absolutely no difference
between deriving from a base class WorkArea that contains the clipboard
methods and deriving from two base classes that contain the same methods.
The idea is that if needed, the new Clipboard class could retrieve the
work_area pointer from the main frontend class (as defined above).
How would it work with multiple work areas? If you have an idea how to do
that then it is fine with me.
Given the fact that there is presently _no_ support for multiple work
areas it would be a progress anyway to modularize that. Remember that a
clipboard is unique per application not per WorkArea.
I think stagnation is bad. I think that my proposal would ease the path
to multiple workAreas in the future. So, would you like me to work on
that or no?
As I already wrote: I don't see the urgent need to do this cleanup.
I need the change for qt4 as I don't like to turn around the kernel API.
So _I_ see the urgent need.
I can
see long term improvements, and if you are going to do that then I want
to have a result that is better than what we have now. That means: Don't
trade one hack (e.g. clipboard in WorkArea) for a new one (e.g. XWorkarea
== XClipboard).
On this last point, as I said earlier, we already have Workarea ==
Clipboard for all frontends so I am not inventing something here.
Thanks,
Abdel.