On Tue, May 30, 2006 at 11:54:24PM +0000, Angus Leeming wrote: > Enrico Forestieri <[EMAIL PROTECTED]> writes: > >> Do you need to consider also mixed \ and / delimiters, as in "foo/bar\baz" > >> ? > > I was not thinking of that, even if I just checked that it works. > > Are you sure? Won't > p = strrchr(arg, '/'); > return > "bar\baz" > ?
I meant that a path like that would work on Windows, not that it would work with this code :) > What about "foo/bar/"? Will the code handle this safely? Hey Angus, that's not my code. That patch only assures that the original code behaves the same whether you use "/" or "\" as a path separator (and not both at the same time). If the code is broken in some corner cases, it remains broken. > > I simply had in mind that a Windows user would probably use "\" > > rather than "/" as a path separator. > > Sure. That's why posting patches for review is a good idea. Agreed. But what's your point? I didn't mean to correct the possibly broken dvipost code but only to let it work (or not work) on Windows in the same way it works (or doesn't work) on *nix. -- Enrico
