Hi,

this removes a redundant check as proposed by Jean-Marc.

Michael
Index: BufferView_pimpl.C
===================================================================
--- BufferView_pimpl.C	(Revision 13821)
+++ BufferView_pimpl.C	(Arbeitskopie)
@@ -1081,17 +1081,20 @@
 	case LFUN_CHANGES_OUTPUT: {
 		OutputParams runparams;
 		LaTeXFeatures features(*buffer_, buffer_->params(), runparams);
-		flag.enabled(buffer_ && features.isAvailable("dvipost"));
+		flag.enabled(features.isAvailable("dvipost"));
 		flag.setOnOff(buffer_->params().output_changes);
 		break;
 	}
 
 	case LFUN_CHANGES_MERGE:
-	case LFUN_CHANGE_ACCEPT: // what about these two
-	case LFUN_CHANGE_REJECT: // what about these two
+	case LFUN_CHANGE_ACCEPT:
+	case LFUN_CHANGE_REJECT:
 	case LFUN_ALL_CHANGES_ACCEPT:
 	case LFUN_ALL_CHANGES_REJECT:
-		flag.enabled(buffer_);
+#ifdef WITH_WARNINGS
+#warning MG: LFUNs should only be enabled if there is actually a change
+#endif
+		flag.enabled(true);
 		break;
 
 	case LFUN_BUFFER_TOGGLE_COMPRESSION: {

Reply via email to