Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> This patch will get rid of the test on "limit.h" Any
Abdelrazak> objection?

As Angus pointed out, I think this is not a very good idea.

There are reasons why these tests are there. And there are systems
(*BSD) which are really different from linux.

Perhaps but please look at the actual patch before making a decision. I am almost certain that this include is not needed at all. So a simpler patch would be to just erase them. "qttableview" in qt3 is some code stolen for Qt2 source code, it is not used at all in qt4 (replaced with QTableWidget IIRC).

Keeping a test for something we don't use is wrong IMHO. Then, if a need for this is coming back in the future, we should use a _portable_ header. Scons or not, this kind of cleanup is a good thing IMHO. But I will stop if there is resistance to that.

Abdel.

Reply via email to