On Sun, Apr 30, 2006 at 06:42:28PM +0200, Georg Baum wrote: > Am Freitag, 28. April 2006 17:35 schrieb Enrico Forestieri: > > On Fri, Apr 28, 2006 at 04:52:02PM +0200, Georg Baum wrote: > > > - send patches against 1.4 (step by step, one fix = one patch) > > > > I was asked to send patches for trunk. Please, make your mind. > > That is true. First comes trunk, then 1.4.
I have no problem to provide patches for both. BTW I always test them on both trunk and 1.4 to see if they apply unmodified to both. Not only, I also try compiling on Solaris to check that they break nothing in a non-cygwin environment. I could do it also on Debian, but that's installed on another partition of my laptop and would be too cumbersome. All in all, I send a patch only after testing such that to be sure that no obious bug is introduced. You know, it takes a life to build a reputation and one minute to lose it. > > > - explain why it is needed > > > - explain how well it is tested > > > - explain potential risks (or the lack thereof) > > > - ask for inclusion > > > > I think I always did so. > > Yes, for trunk. > > > > - commit it (yourself) if OK > > > > Cannot do it. > > But that is not set in stone. BTW I got commit access because André was > tired to put my tex2lyx fixes in. I am neither a developer nor proficient in C++, so I don't think that I can give a significant contribution to LyX. > > > I am sure that you will get more positive feedback if you follow this > > > procedure. Obviously nobody has enough time, therefore everybody does > what > > > he cares about most. > > > > Here is the problem. Nobody cares about cygwin, ergo it is not well > accepted. > > If you mean by not well accepted that nobody besides you (and Abdel and Bo > sometimes) is actively trying to fix it, then I agree. If you mean that > cygwin fixes are ignored although you do your share of the work then I > don't agree. After all several fixes made it into 1.5. It is a problem conveying a concept when you don't speak in your mother tongue, but you got it. I meant right that, ie, if nobody of you can appreciate or take advantage of a fix, it simply is a waste of time. I understand that. > > I understand you and I don't want to be a PITA, so I think that the only > > solution is that I should give up trying to have my patches applied > > to the official sources. > > Maybe it was not such a good idea of mine to post that friday-language > post one minute before going away, but I thought that everybody knew > about that rule. Anyway, since it has now been explained I hope you did > not take any offense. Yep, I didn't know that. I had only got that on Friday no smileys could be used (for a misterious reason to me). Anyway, I didn't take any offense. I think that it also happened to me to say something above the lines, with the aggravating circumstance that perhaps it was not on Friday ;-) -- Enrico
